[native_assets_cli] Split up syntax generator #2106
Merged
+754
−877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #1826
More refactorings to
package:json_syntax_generator
.setOrRemove
to remove branching in setters for nullable values.optionalListParsed
to immediately parse list elements, to remove loops in getters.$dartType
instead of spelling out types. This simplified generation of getters/setters for simplified types to a simple 10 lines. (Yay for a niceDartType
abstraction!)if (required)
branching and instead made the relevant parts be variables.