Skip to content

[native_assets_cli] Stop reading version #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

dcharkes
Copy link
Collaborator

Bug: #93

Remove any reads of version in the protocol.

We're moving towards a world where deprecations and breaking changes are per property and documented via the JSON schemas. So we don't use version numbers anymore.

  • Change the syntax to make version nullable.
  • Still write the last known version (to avoid breaking older hooks and older SDKs with newer SDKs and hooks).
  • Remove the version from the semantic API.
  • Remove all checks that were checking for versions.
    • Note: this regresses error messages, and this is intended.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the remove-version-checks branch from baec0f7 to aee1809 Compare March 27, 2025 16:10
@dcharkes dcharkes requested a review from mosuem March 27, 2025 16:10
@dcharkes dcharkes marked this pull request as ready for review March 27, 2025 16:10
@dcharkes dcharkes force-pushed the namespace-asset-types branch from b91277d to be91927 Compare March 28, 2025 16:51
Base automatically changed from namespace-asset-types to main March 28, 2025 17:06
@dcharkes dcharkes force-pushed the remove-version-checks branch from aee1809 to 027d09e Compare March 28, 2025 21:12
@auto-submit auto-submit bot merged commit 75f3408 into main Mar 28, 2025
46 checks passed
@auto-submit auto-submit bot deleted the remove-version-checks branch March 28, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants