Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jni] chore: bump compileSdk #2167

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lsaudon
Copy link

@lsaudon lsaudon commented Apr 3, 2025


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@lsaudon lsaudon changed the title chore: bump compileSdk [jni] chore: bump compileSdk Apr 3, 2025
Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lsaudon ! 🙏

LGTM to the native_toolchain_c changes. 👍

@HosseinYousefi would you please review the JNIgen changes?

Copy link

github-actions bot commented Apr 4, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
jni Breaking 0.14.1 0.14.1 0.15.0
Got "0.14.1" expected >= "0.15.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
jni _ReferenceType
_opaque_pthread_mutex_t
_opaque_pthread_cond_t
_Dart_FinalizableHandle

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 85.975%. first build
when pulling 0feddcf on lsaudon:chore/bump-compilesdk
into 8c39c95 on dart-lang:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants