[record_use] Integration test case for library-uris #2987

dcharkes · 2026-01-20T15:45:40Z

A test case to use for

[record_use] Correctness: Specify what uris are used #2891

The test case checks:

the library uri for a definition inside lib/ (should be package uri)
the library uri for a definition inside another packages' lib/ (should be package uri)
the library uri for a definition outside lib/ (what should the canonical uri be of this? I left an open TODO.)
the library uri for a use inside lib/ (should be package uri)
the library uri for a use inside another packages' lib/ (should be package uri)
the library uri for a use outside lib/ (what should the canonical uri be of this? I left an open TODO.)

See the linked issue for the current state of the VM and dart2js implementation.

github-actions · 2026-01-20T15:48:01Z

PR Health

License Headers ✔️

// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/jni/test/debug_release_test.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
hooks_runner	None	1.0.1	1.0.2-wip	1.0.1	✔️
record_use	Breaking	0.4.2	0.5.0-wip	0.5.0	✔️

This check can be disabled by tagging the PR with skip-breaking-check.

github-actions · 2026-01-20T15:48:06Z

PR Health

License Headers ✔️

// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/jni/test/debug_release_test.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
record_use	Breaking	0.4.2	0.5.0-wip	0.5.0	✔️

This check can be disabled by tagging the PR with skip-breaking-check.

coveralls · 2026-01-20T16:00:35Z

coverage: 81.798% (-0.008%) from 81.806%
when pulling 9f69269 on record-use-library-uris
into 6127a50 on main.

pkgs/record_use/lib/src/location.dart

pkgs/record_use/test_data/library_uris/pubspec.yaml

pkgs/record_use/test_data/library_uris_helper/pubspec.yaml

pkgs/record_use/test_data/library_uris/pubspec.yaml

pkgs/record_use/lib/src/reference.dart

pkgs/record_use/test_data/library_uris/hook/link.dart

goderbauer · 2026-01-21T10:15:37Z

pkgs/record_use/test_data/library_uris/hook/link.dart

This hook seems to really be a test. Does it run on CI? It wasn't immediately clear to my what triggered it there...

Might also be worthwhile to document on top of this file that really, it's the test.

We will trigger it on the Dart CI. This is a test data project. I'm working on
the Dart SDK CL.

Let's document for future readers here (and maybe on the pubspec) that that's how it is run on CI.

All test_data/ projects in pkgs/hooks_runner/ follow the same project btw.

goderbauer · 2026-01-21T10:17:16Z

pkgs/record_use/test_data/library_uris/pubspec.yaml

+
+  For dart2js, `dart compile js --write-resources` and inspect the contents of
+  the file.
+


Soo... is just just a manual test? Can we automate it (i.e. the inspecting of the content of the file) and run it on CI?

We will automate it inside the Dart SDK, not on dart-lang/native. (Running it
here would be bad, we would see fixes and breakages only on dev and stable
releases.)

mosuem · 2026-01-21T11:02:27Z

General thought: toString is not great if meant for more than just debugging strings - it's hard to find usages etc. I would prefer a custom method for that.

goderbauer · 2026-01-21T10:57:59Z

pkgs/record_use/test/to_string_test.dart

+        positionalArguments: [null],
+        namedArguments: {'bar': null},


Let's include an additional test with multiple arguments for both? (The current one wouldn't have caught the , typo)

goderbauer · 2026-01-21T11:00:39Z

pkgs/record_use/test_data/library_uris/hook/link.dart

Let's document for future readers here (and maybe on the pubspec) that that's how it is run on CI.

dcharkes · 2026-01-21T11:04:35Z

General thought: toString is not great if meant for more than just debugging strings - it's hard to find usages etc. I would prefer a custom method for that.

It's for debugging, that is what I was doing. I don't want to add something for users, but we can't not do it if we want debugging info ourselves.

dcharkes · 2026-01-21T11:05:16Z

I can also remove all the toString stuff and let Gemini generate it again the next time I need it 😆 It's not the point of this PR.

goderbauer

LGTM

[record_use] Integration test case for library-uris

3744ca0

dcharkes added the skip-changelog-check label Jan 20, 2026

add second package to the mix

3276948

dcharkes requested review from goderbauer and mosuem January 20, 2026 16:15

goderbauer reviewed Jan 21, 2026

View reviewed changes

dcharkes added 2 commits January 21, 2026 11:29

generate the manifest

da57aa5

add a record-use definition outside lib

f7bbaa6

github-actions bot added the package:hooks_runner label Jan 21, 2026

dcharkes mentioned this pull request Jan 21, 2026

[infra] use dependency_validator #2992

Open

dcharkes added 2 commits January 21, 2026 11:52

address comments

35cbfda

try debug manifest generator

7119cdc

goderbauer reviewed Jan 21, 2026

View reviewed changes

dcharkes added 2 commits January 21, 2026 12:09

address comments

168d60b

fix manifest

9f69269

dcharkes requested a review from goderbauer January 21, 2026 11:15

goderbauer approved these changes Jan 21, 2026

View reviewed changes

dcharkes added the autosubmit label Jan 21, 2026

dcharkes merged commit bf77b81 into main Jan 21, 2026
29 checks passed

dcharkes deleted the record-use-library-uris branch January 21, 2026 11:27

marinkobabic pushed a commit to marinkobabic/native that referenced this pull request Jan 21, 2026

[record_use] Integration test case for library-uris (dart-lang#2987)

45a7006

marinkobabic pushed a commit to marinkobabic/native that referenced this pull request Jan 21, 2026

[record_use] Integration test case for library-uris (dart-lang#2987)

55b6a55

Hassnaa9 pushed a commit to Hassnaa9/native that referenced this pull request Jan 22, 2026

[record_use] Integration test case for library-uris (dart-lang#2987)

d42d38c


		For dart2js, `dart compile js --write-resources` and inspect the contents of
		the file.

[record_use] Integration test case for library-uris #2987

[record_use] Integration test case for library-uris #2987

Uh oh!

Conversation

dcharkes commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

github-actions bot commented Jan 20, 2026

PR Health

Uh oh!

coveralls commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mosuem commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcharkes commented Jan 21, 2026

Uh oh!

dcharkes commented Jan 21, 2026

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dcharkes commented Jan 20, 2026 •

edited

Loading

github-actions bot commented Jan 20, 2026 •

edited

Loading

coveralls commented Jan 20, 2026 •

edited

Loading