Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter SDK package 'flutter' from the outdated report. #1453

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Mar 17, 2025

No description provided.

@isoos isoos requested review from jonasfj and sigurdm March 17, 2025 07:42
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to filter all sdk packages out.

I think we need to either read pubspec.lock or the output of dart pub deps to know the source of the dependencies (the source of direct dependencies can be read from the pubspec.yaml, but for transitive dependencies we need one of those)

@isoos
Copy link
Collaborator Author

isoos commented Mar 17, 2025

Would it be enough to filter the source: sdk in pubspec.lock?

@sigurdm
Copy link
Contributor

sigurdm commented Mar 17, 2025

Would it be enough to filter the source: sdk in pubspec.lock?

Yes, I think that is the best way to do it!

@isoos isoos requested a review from sigurdm March 17, 2025 11:56
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@isoos isoos merged commit 07bd483 into dart-lang:master Mar 17, 2025
5 checks passed
@isoos isoos deleted the outdated branch March 17, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants