Temporary dartdoc workaround: remove leading href parents from extension type sidebars.#7496
Merged
isoos merged 2 commits intodart-lang:masterfrom Feb 22, 2024
Merged
Conversation
Collaborator
isoos
commented
Feb 22, 2024
- This is only a temporary measure to unblock the site until extension type sidebar has a href bug after being loaded in the browser dartdoc#3663 gets fixed.
- As the sidebars are already broken, there is little risk to do a crude string replace (before sanitization).
…ion type sidebars.
Collaborator
Author
|
Note: this has been verified locally with |
Contributor
|
Are we sure there are no other places we generate |
Collaborator
Author
I think the risk is very low to that:
|
sigurdm
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.