Skip to content

Temporary dartdoc workaround: remove leading href parents from extension type sidebars.#7496

Merged
isoos merged 2 commits intodart-lang:masterfrom
isoos:hack-dartdoc-bug
Feb 22, 2024
Merged

Temporary dartdoc workaround: remove leading href parents from extension type sidebars.#7496
isoos merged 2 commits intodart-lang:masterfrom
isoos:hack-dartdoc-bug

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Feb 22, 2024

@isoos isoos requested review from jonasfj and sigurdm February 22, 2024 09:26
@isoos
Copy link
Collaborator Author

isoos commented Feb 22, 2024

Note: this has been verified locally with package:web.

@sigurdm
Copy link
Contributor

sigurdm commented Feb 22, 2024

Are we sure there are no other places we generate ../ that are going to break as a result of this?

@isoos
Copy link
Collaborator Author

isoos commented Feb 22, 2024

Are we sure there are no other places we generate ../ that are going to break as a result of this?

I think the risk is very low to that:

  • We are filtering on extension type sidebars via the filename.
  • In addition to that, the regular sidebar does not have the ../ segment in the hrefs in the first place (hence the bug).
  • I'd expect that the dartdoc fix will remove the leading ../ we are just doing it in a not-that-nice way.

@isoos isoos merged commit 1eb10f8 into dart-lang:master Feb 22, 2024
@isoos isoos deleted the hack-dartdoc-bug branch February 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants