Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced memory use on processing the new upload. #8222

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Nov 1, 2024

  • This is a the low-hanging fruit before having an implementation of separate isolates (Move upload checks into a separate isolate. #8195).
  • Hash calculation is stream based, and content comparison depends on the chunk of bytes we get back from the storage bucket. In theory this could be still arbitrarily large, but in practice I think it won't be.

@isoos isoos requested a review from jonasfj November 1, 2024 15:42
@isoos
Copy link
Collaborator Author

isoos commented Nov 1, 2024

Note: I think the separate isolate refactor will take a lot of work, as we need to setup a full service environment in that isolate to make it work through all of the interdependent code (especially bucket access). However, this change may deliver a small benefit before we find enough time to do the refactor with isolates.

@isoos isoos merged commit 5ad76e1 into dart-lang:master Nov 7, 2024
32 checks passed
@isoos isoos deleted the reduced-memory branch November 7, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants