-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Flutter Favorite banners #8624
Conversation
Thanks for doing, they do look nicer - I wonder if they are too dark? - I tried making a screenshot of the package page with this @isoos @szakarias @jonasfj WDYT? |
I think the white-ish text color could be a slightly darker, but otherwise I think this is fine. |
It looks awesome @brainwo! 100x improvement over the current logo. |
Much better IMO |
This is awesome 🚀 CC @anderdobo for Flutter Favorite perspective. |
Here are the SVG files if anyone needs them: ff-banner-mobile-dark-2x (note: the "Flutter Favorite" text is exported as SVG path) |
Looks good to me, @anderdobo wdyt? |
@jonasfj do you think we'll use these? If so, we should get them into the PR itself so they are part of the CLA. |
We could probably use the svgs instead of the pngs, but for the scope of this PR, it is fine if those files are just alongside the png versions. |
@brainwo yes, if you could add the svgs to the pr itself it would be helpful, then we can use them later if we need to derive new versions of the logo. |
LGTM. Thank you! |
Thanks! |
A popular request in
dart_community
Discord server.The banner was a part of a custom user theme for pub.dev I created. But due to high interest in Discord, I decided to create this pull request.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.