Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Flutter Favorite banners #8624

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Better Flutter Favorite banners #8624

merged 3 commits into from
Mar 11, 2025

Conversation

brainwo
Copy link
Contributor

@brainwo brainwo commented Mar 7, 2025

A popular request in dart_community Discord server.

The banner was a part of a custom user theme for pub.dev I created. But due to high interest in Discord, I decided to create this pull request.

image


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@sigurdm
Copy link
Contributor

sigurdm commented Mar 7, 2025

Thanks for doing, they do look nicer - I wonder if they are too dark? - I tried making a screenshot of the package page with this

image

@isoos @szakarias @jonasfj WDYT?

@isoos
Copy link
Collaborator

isoos commented Mar 7, 2025

I think the white-ish text color could be a slightly darker, but otherwise I think this is fine.

@brainwo
Copy link
Contributor Author

brainwo commented Mar 7, 2025

image

How about this? I tried matching the preexisting colours.

@Wdestroier
Copy link

It looks awesome @brainwo! 100x improvement over the current logo.

@sigurdm
Copy link
Contributor

sigurdm commented Mar 7, 2025

image

@mateusfccp
Copy link
Contributor

Much better IMO

@jonasfj jonasfj requested a review from mit-mit March 7, 2025 11:43
@jonasfj
Copy link
Member

jonasfj commented Mar 7, 2025

This is awesome 🚀

CC @anderdobo for Flutter Favorite perspective.

@brainwo
Copy link
Contributor Author

brainwo commented Mar 8, 2025

Here are the SVG files if anyone needs them:

ff-banner-mobile-dark-2x
ff-banner-desktop-dark-2x

(note: the "Flutter Favorite" text is exported as SVG path)

@mit-mit
Copy link
Member

mit-mit commented Mar 10, 2025

Looks good to me, @anderdobo wdyt?

@mit-mit
Copy link
Member

mit-mit commented Mar 10, 2025

Here are the SVG files if anyone needs them:

ff-banner-mobile-dark-2x ff-banner-desktop-dark-2x

(note: the "Flutter Favorite" text is exported as SVG path)

@jonasfj do you think we'll use these? If so, we should get them into the PR itself so they are part of the CLA.

@isoos
Copy link
Collaborator

isoos commented Mar 10, 2025

We could probably use the svgs instead of the pngs, but for the scope of this PR, it is fine if those files are just alongside the png versions.

@sigurdm
Copy link
Contributor

sigurdm commented Mar 10, 2025

@brainwo yes, if you could add the svgs to the pr itself it would be helpful, then we can use them later if we need to derive new versions of the logo.

@anderdobo
Copy link

LGTM. Thank you!

@sigurdm sigurdm merged commit 4f1b7dd into dart-lang:master Mar 11, 2025
7 checks passed
@sigurdm
Copy link
Contributor

sigurdm commented Mar 11, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants