Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce TestProfile mutable API: uploaders can be inferred directly from the profile. #8640

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Reduce TestProfile mutable API: uploaders can be inferred directly from the profile. #8640

merged 1 commit into from
Mar 13, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Mar 13, 2025

  • Follow-up to TestProfile packages: explicit imported and generated fields. #8634.
  • The update-only mutability of TestPackage makes it harder to subclass it (especially if the TestVersion is also going to subclassed). Since we can infer the same default uploader from the TestProfile during import, there is no need to update it.
  • Note: I'm planning to also remove the versions update in a subsequent PR.

@isoos isoos requested review from jonasfj and sigurdm March 13, 2025 11:55
@isoos isoos merged commit e1fb48f into dart-lang:master Mar 13, 2025
31 checks passed
@isoos isoos deleted the normalizer-uploaders branch March 13, 2025 12:16
@isoos isoos mentioned this pull request Mar 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm