Refactor task backend's low-level data access. #8710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatastoreDB.tasks.lookupOrNull('pkg')
calls, which should be easy to reason about and also replace with their SQL counterparts.updateDependencyChanged
orbumpPriority
) are easy to refactor enclosing the transaction logic, but others (e.g. thetrackPackage
method) is not that easy, and kept it as-is for now.insert
/update
methods, not really sure if it is helpful, but at least we have a quick overview where we are updating/inserting the entities.