Skip to content

Refactor task backend's low-level data access. #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Apr 18, 2025

  • An iteration over RFC: Options to SQL-migration. #8705.
  • Uses extensions methods to create a short-lived wrapper object that allows DatastoreDB.tasks.lookupOrNull('pkg') calls, which should be easy to reason about and also replace with their SQL counterparts.
  • Some transactional update methods (e.g. updateDependencyChanged or bumpPriority) are easy to refactor enclosing the transaction logic, but others (e.g. the trackPackage method) is not that easy, and kept it as-is for now.
  • Separated the insert/update methods, not really sure if it is helpful, but at least we have a quick overview where we are updating/inserting the entities.

@isoos isoos requested review from jonasfj and sigurdm April 18, 2025 11:44
@isoos
Copy link
Collaborator Author

isoos commented Apr 29, 2025

wdyt @jonasfj @sigurdm?

@isoos isoos merged commit 3cfd012 into dart-lang:master May 1, 2025
31 checks passed
@isoos isoos deleted the task-refactor branch May 1, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants