Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "pub run --list" command to show all available executables. #1427

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

antonmoiseev
Copy link
Contributor

See #1323

@nex3
Copy link
Member

nex3 commented Jul 6, 2016

See comments here.

@antonmoiseev
Copy link
Contributor Author

@nex3 Natalie, I've addressed your comments, I think it's ready for review, please take a look.

@nex3
Copy link
Member

nex3 commented Jul 22, 2016

The more I think about it, the more I feel like this doesn't belong under pub run. It does something completely different than running an executable, and none of the existing pub run options make sense along with --list. I think maybe it would make more sense as an option to pub deps, especially since it only prints dependency executables now. Maybe pub deps --executables?

@antonmoiseev
Copy link
Contributor Author

antonmoiseev commented Jul 22, 2016

I don't have a strong opinion on this one, just some considerations:

  1. From organizational point of view pub deps looks like a better place
  2. I think users will more likely discover it under pub run
  3. pub deps is a more natural place for executables from dependencies, but not sure about executables defined in the current app

Anyway, I'm totally fine with any option you decide is the right thing to do. Let me know if you want me to move it to pub deps.

@nex3
Copy link
Member

nex3 commented Jul 22, 2016

I agree it's more discoverable under pub run, and if it could have subcommands that's what I'd recommend. But that would conflict with running executables, and I don't like making flags do the work of subcommand.

For point 3, pub deps already lists the current executable when listing deps, so I don't think it's too weird.

@antonmoiseev
Copy link
Contributor Author

OK, moving it to pub deps. Should it respect the --dev flag?

@nex3
Copy link
Member

nex3 commented Jul 22, 2016

Yeah, it should.

@nex3
Copy link
Member

nex3 commented Dec 5, 2016

@antonmoiseev Are you planning on iterating on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants