Test package APIs rather than resource APIs. #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munificent
approved these changes
Sep 28, 2016
| @@ -0,0 +1,99 @@ | |||
| // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file | |||
| cachePath, | ||
| "hosted/localhost%58${await globalPackageServer.port}/bar-1.0.0/" | ||
| "lib/resource.txt")) | ||
| .toString()); |
There was a problem hiding this comment.
These three statements got wrapped an awful lot. It might be cleaner to declare little local variables for each path.
| print(await Isolate.resolvePackageUri( | ||
| Uri.parse('package:foo/resource.txt'))); | ||
| } | ||
| """) |
There was a problem hiding this comment.
This is the same string as the above script, right? If so, declare a constant for it. Ideally stick it somewhere that the run/package_api_test can get to it too.
There was a problem hiding this comment.
Done. I didn't share it across files, though, because I couldn't think of a nice semantic thing to call it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1446