Avoid barback for precompilation if possible. #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were always loading an AssetEnvironment when we precompiled any executable. Now we only load that environment if some package dependended on by some executable actually uses a transformer. Otherwise, we precompile from disk. The new approach is substantially faster and produces better error messages. Closes #1473
nex3
force-pushed
the
barback-free-snapshots
branch
from
34d93e0 to
027b707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were always loading an AssetEnvironment when we
precompiled any executable. Now we only load that environment if some
package dependended on by some executable actually uses a transformer.
Otherwise, we precompile from disk. The new approach is substantially
faster and produces better error messages.
Closes #1473