Modify error message for const (ASSIGNMENT_TO_CONST) #56953
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Frankdroid7
force-pushed
the
modify_error_message
branch
from
9db7e73
to
f563d46
Compare
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/391489 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Hi @Frankdroid7 can you please take a look at the review feedback in https://dart-review.googlesource.com/c/sdk/+/391489 ? |
|
Yes, we can go with this as the error message @mit-mit |
|
https://dart-review.googlesource.com/c/sdk/+/391489 has been updated with the latest commits from this pull request. |
|
I'm not sure what happened, but this PR only has one commit that I can see. Copybara copied the same commit to the CL, so there are no changes between the first and second patches. Could you please try uploading the commit with your latest changes again? |
|
Sure, will do that.
…On Wed, Nov 6, 2024 at 6:44 PM Brian Wilkerson ***@***.***> wrote:
I'm not sure what happened, but this PR only has one commit that I can
see. Copybara copied the same commit to the CL, so there are no changes
between the first and second patches. Could you please try uploading the
commit with your latest changes again?
—
Reply to this email directly, view it on GitHub
<#56953 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKSQN3QQNU6SJNLOUCZNSDZ7JPRHAVCNFSM6AAAAABQQ3UTSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRQGUZDANJVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Pushed a new commit |
|
https://dart-review.googlesource.com/c/sdk/+/391489 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/391489 has been updated with the latest commits from this pull request. |
|
Thanks! I left some additional comments on the CL (https://dart-review.googlesource.com/c/sdk/+/391489). |
Dart says
Constant variables can't be assigned a value., when you try to reassign a value to a const variable.I feel a better error description should have been
Constant variables can't be re-assigned a value.This is because we are trying to re-assign it not assign it at this point. The assignment has already been done.
Thanks.