[json] add datetime support #57063
[json] add datetime support #57063
Conversation
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/394401 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
cedvdb
changed the title
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
cedvdb
changed the title
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
2 similar comments
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
| @@ -16,6 +16,7 @@ void main() { | |||
| 'intField': 10, | |||
| 'doubleField': 12.5, | |||
| 'numField': 11, | |||
| 'dateTimeField': '2024-11-11T03:42:29.108308', | |||
There was a problem hiding this comment.
Don't judge me, I need to fix my sleep schedule :S
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
|
My reply to you on gerrit is marked as draft and I don't know how to publish it so I'm answering here: JSON itself does not specify how dates should be represented, but JavaScript does (JavaScript Object Notation). To me this authority is compelling enough but to add to that:
Using a number of milliseconds or seconds or nanoseconds has the issue that the program deserializing has to have knowledge of the unit. This is a real issue when using various services and language that each have their unit. Using a map is not always sortable and uses more bandwidth. |
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/394401 has been updated with the latest commits from this pull request. |
100%, if we all agree that we should also provide (at some point) support for specifying how DateTime format will be encoded out of the box, then we could contemplate creating an issue to track the effort and be open to external contributions. |
|
@cedvdb Can you apply this patch and upload it? https://gist.github.com/jakemac53/fa4bbab983446b036a769c2c2c2a6a91 This adds some additional tests, cleans up the output a bit for some other cases, and fixes nullable dates in collections. |
Fix #56175
toIsoandparsewere used as the implementation. This seem like a decent choice as Javascript also uses iso as the default serialization method for dates.Add date
Contribution guidelines:
dart format.Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.