fix(android): return correct path when saving a file#1
Draft
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Draft
fix(android): return correct path when saving a file#1google-labs-jules[bot] wants to merge 1 commit intomasterfrom
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Conversation
The `saveFile` method on Android was returning a path to the `Download` folder regardless of the directory picked by the user. This was because `uri.getPath()` was used to get the path from the content URI, which does not always return a real file system path. This commit fixes the issue by adding a new `getPath` utility function that correctly resolves the absolute file path from the content `Uri` returned by the native file picker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, the
saveFilemethod was returning a path to theDownloadfolder regardless of the directory picked by the user. This was becauseuri.getPath()was used to get the path from the content URI, which does not always return a real file system path. This commit fixes the issue by adding a newgetPathutility function that correctly resolves the absolute file path from the contentUrireturned by the native file picker.