feat: Respect accessibility setting for animations#6
Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Draft
feat: Respect accessibility setting for animations#6google-labs-jules[bot] wants to merge 1 commit intomainfrom
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the Mattermost mobile app respects the system-wide accessibility setting for animations.
A new utility function
areAnimationsEnabledis introduced inapp/utils/accessibility.ts. This function checks theisReduceMotionEnabledstatus from React Native'sAccessibilityInfoAPI.The main navigation logic in
app/screens/navigation.tshas been updated to use this function. Several functions responsible for screen transitions and modal presentations have been madeasyncto await the result ofareAnimationsEnabled. Based on this result, animations are either enabled or disabled for various navigation actions, including screen pushes, modal presentations, and bottom sheets.This change addresses the issue where animations were still present even when disabled in the device's accessibility settings.