ProfileScreen: Use NavRows and a TextRow instead of ZulipButtons

[supra08]

We've been using a NavRow and a SwitchRow for the first two interactive items ("Set your status" and "Invisible mode"), and I think the screen looks more coherent if we use NavRows and a TextRow for these other interactive items too. For one thing, now all the text on the screen is the same color.

[dashwave]

Build Status	✅ Successful
Build Time	26s
📱 Emulation Link	https://console.dashwave.io/emulator/1705/preview?device=emulator
Logs	See Logs

[supra08]

@dashwave /review

[dashwave]

Pull Request

Title

ProfileScreen: Replace View Components with NavRow and TextRow

What is this?

In the existing ProfileScreen.js, different text colors were used for interactive items. This pull request aims to create a more visually cohesive design by using NavRow and TextRow components for all interactive items on the screen. This change will ensure that all text on the profile screen remains uniform in color, enhancing user experience and consistency.

Changes

Code Changes:

1. In ProfileScreen.js:
   • Removed redundant imports: View, UserId, createStyleSheet, and ZulipButton.
   • Eliminated custom ProfileButton, SettingsButton, SwitchAccountButton, and LogoutButton components that used ZulipButton for individual button handling.
   • Introduced NavRow and TextRow components to replace the aforementioned to reduce complexity and improve UI consistency.
   • Utilized NavRow for the "Full profile", "Settings", and "Switch account" features.
   • Utilized TextRow for the "Log out" feature which also retains the confirmation dialog structure.

Documentation Updates:

There were no specific documentation updates made directly in this pull request. The existing structure and documentation sufficed for the changes introduced.

---

Pull Request Review

Code Review

The refactoring of ProfileScreen.js to replace individual button components (ZulipButton) with NavRow and TextRow is well-executed. The approach eliminates repetitive code while maintaining the same functionality, thus enhancing maintainability.

Readability and Best Practices

• The code is clean, concise, and follows industry-standard practices.
• Use of NavRow and TextRow components improves the UI consistency.
• The refactoring leads to less dependency on custom styling and repetitive button components.

Integration

• Integrates smoothly with the existing codebase. Uses existing NavRow and TextRow components effectively.
• Removed unnecessary imports, reducing the overall complexity of the file.

Documentation and Comments

• Code changes are self-explanatory and align with existing naming conventions.
• Inline comments and function documentation were deemed unnecessary as the logic and changes are straightforward.

Recommendations

• Ensure thorough testing of the profile screen to validate that all interactive elements function correctly following the refactor.
• Consider whether additional documentation or comments are necessary for new contributors who may not be familiar with NavRow and TextRow components.

Overall, this refactoring makes the ProfileScreen.js file more coherent and easier to maintain without compromising existing functionalities.