feat: add dak.zip_no_broadcast #567
Conversation
src/dask_awkward/lib/io/io.py
Outdated
| @@ -468,7 +468,7 @@ def to_dataframe( | |||
| """ | |||
| import dask | |||
| from dask.dataframe import DataFrame as DaskDataFrame | |||
| from dask.dataframe.core import new_dd_object # type: ignore | |||
| from dask.dataframe.core import new_dd_object | |||
There was a problem hiding this comment.
This does not work with new dask, this is the problem that needs fixing. I don't know if that has any implication for this PR.
There was a problem hiding this comment.
my pre-commit did complain about this - ah maybe I was on an old dask version locally?
There was a problem hiding this comment.
I suppose it's fine either way, we know this code is OK on python 3.9 (which never got the new dask) and doesn't work on newer versions at all.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 93.06% 92.08% -0.99%
==========================================
Files 23 24 +1
Lines 3290 3613 +323
==========================================
+ Hits 3062 3327 +265
- Misses 228 286 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Awkward-array v2.7.4 introduces
ak.zip_no_broadcastwhich is useful for coffea to construct arrays without touching unwanted buffer keys. This PR implements thedakequivalent.