Skip to content

fix: remove index_nplike #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pfackeldey
Copy link
Collaborator

Awkward does not support index_nplike anymore with scikit-hep/awkward#3446 (we need to wait for a new release here). This PR replaces index_nplike with nplike.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (8cb8994) to head (8263b62).
Report is 252 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   93.06%   92.10%   -0.97%     
==========================================
  Files          23       24       +1     
  Lines        3290     3596     +306     
==========================================
+ Hits         3062     3312     +250     
- Misses        228      284      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martindurant
Copy link
Collaborator

This looks complete - any reason to keep it as draft?

@pfackeldey
Copy link
Collaborator Author

I wanted to wait for the corresponding awkward release and pin the version. Not sure when we get it'll be released though.

@martindurant
Copy link
Collaborator

Isn't it the case that index_nplike went away, but nplike was already there - so it doesn't need the latest awkward at all? Or maybe I misunderstood.

@pfackeldey
Copy link
Collaborator Author

Oh you're completely right! Somehow I haven't thought about this being backwards compatible, but it is 😅

@pfackeldey pfackeldey marked this pull request as ready for review April 15, 2025 12:39
@martindurant martindurant merged commit ef84eaf into dask-contrib:main Apr 15, 2025
49 of 54 checks passed
@martindurant
Copy link
Collaborator

OK, now let's do #578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants