Skip to content

fix: explicit primitive promotion for scalar typetracer arrays #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pfackeldey
Copy link
Collaborator

This fixes: #578 (comment)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (8cb8994) to head (91e1d64).
Report is 254 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   93.06%   92.10%   -0.97%     
==========================================
  Files          23       24       +1     
  Lines        3290     3596     +306     
==========================================
+ Hits         3062     3312     +250     
- Misses        228      284      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martindurant
Copy link
Collaborator

OK, I guess. I can't see any obvious down sides of this. Can we check that no copies are made in the normal case? Is it just as fast?

@pfackeldey
Copy link
Collaborator Author

This is just restoring the original behavior, there shouldn't be any performance drawbacks. ak.Array would internally use ak.to_layout to promote a 0-dim typetracer array before. Now we do that explicitly and ak.Array skips this step then.

@martindurant
Copy link
Collaborator

OK +1

@pfackeldey pfackeldey merged commit c0d8ed8 into dask-contrib:main Apr 17, 2025
50 of 54 checks passed
pfackeldey added a commit that referenced this pull request Apr 28, 2025
…xplcit_promotion

fix: forgot this promotion in #580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants