Skip to content

fix: length 0 slices #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Conversation

pfackeldey
Copy link
Collaborator

This fixes slices like array[0:0]. Without this PR dask-awkward would wrongly slice nothing at all, ie returning the original unsliced array.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (8cb8994) to head (c9815f1).
Report is 256 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   93.06%   92.10%   -0.97%     
==========================================
  Files          23       24       +1     
  Lines        3290     3596     +306     
==========================================
+ Hits         3062     3312     +250     
- Misses        228      284      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pfackeldey pfackeldey requested a review from martindurant April 17, 2025 23:38
@martindurant martindurant merged commit 54ef202 into dask-contrib:main Apr 18, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants