fix: avoid dask v2025.4.0 for CI tests #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 93.06% 92.10% -0.97%
==========================================
Files 23 24 +1
Lines 3290 3598 +308
==========================================
+ Hits 3062 3314 +252
- Misses 228 284 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We really need to |
nsmith-
added a commit
to ftorrresd/correctionlib
that referenced
this pull request
Apr 28, 2025
Since dask-awkward does not have a release yet dask-contrib/dask-awkward#582
github-merge-queue bot
pushed a commit
to cms-nanoAOD/correctionlib
that referenced
this pull request
Apr 28, 2025
* Add "--ignore-float-inf" for "correction summary" * Pin dask for tests Since dask-awkward does not have a release yet dask-contrib/dask-awkward#582 --------- Co-authored-by: Nicholas Smith <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI is broken since: dask/dask#11859 (comment)
Need to get a corresponding fix in dask.
Even though the actual code seems to run judging from playing around, I'd be in favor of avoiding this dask release as we can't be entirely sure given that our tests won't run...