Skip to content

fix: forgot this promotion in #580 #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pfackeldey
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (8cb8994) to head (efded5a).
Report is 265 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   93.06%   92.10%   -0.97%     
==========================================
  Files          23       24       +1     
  Lines        3290     3598     +308     
==========================================
+ Hits         3062     3314     +252     
- Misses        228      284      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pfackeldey pfackeldey requested a review from martindurant April 28, 2025 14:06
@pfackeldey
Copy link
Collaborator Author

Hi @martindurant, could you quickly review this one?
This fix was missing to make coffea tests pass again (we have to get this fix in before a new release), and a recent change in uproot forces us to use dependency groups for the uproot main CI test.

@martindurant
Copy link
Collaborator

Yep, jusyt like all the others, +1

@pfackeldey pfackeldey merged commit 75d1999 into dask-contrib:main Apr 28, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants