Metadata forms: List of Attached Forms #1652
Conversation
Number of attached entities per version
|
One bug I see - Env and Org Forms not showing to Attach to S3 Dataset Entity Anymore Just need to change to |
| @@ -38,6 +39,7 @@ const MetadataFormView = () => { | |||
| const tabs = [ | |||
| { label: 'Form Info', value: 'info' }, | |||
| { label: 'Fields', value: 'fields' }, | |||
| { label: 'Attached', value: 'attached' }, | |||
There was a problem hiding this comment.
nit: would suggest change Attached to Attached Entities for clarity
| maxLines: 1 | ||
| }} | ||
| > | ||
| {version.attached_forms} |
There was a problem hiding this comment.
nit: Change to {'Count: ' + version.attached_forms} for clarity
| {' version ' + version.version} | ||
| </Typography> | ||
| </Grid> | ||
| <Grid item lg={3} xl={3}> |
There was a problem hiding this comment.
would suggest to even out spacing, the below seemed more evenly spaced on Versions Table (with including the Count: suggestion below):
L 194-195: lg={5} xl={5}
L214: <Grid item lg={5} xl={5}>
L228: <Grid item lg={1} xl={1}>
or however best to include all information
| <CardContent sx={{ display: 'flex', justifyContent: 'center' }}> | ||
| <DoNotDisturbAltOutlinedIcon sx={{ mr: 1 }} /> | ||
| <Typography variant="subtitle2" color="textPrimary"> | ||
| No Metadata Forms Attached |
There was a problem hiding this comment.
nit: Should be No Metadata Form Versions in this case right?
| <CardHeader title="Versions" /> | ||
|
|
||
| <Divider /> | ||
| {versions.length > 0 ? ( |
There was a problem hiding this comment.
can we wrap this section similarly around a block that if loading is false we show <CircularProgress /> and if true we show the version options
or use a new loadingVersion state variable if better UX
++ can we set loading state initially to true so it begins in this loading state until MF forms are populated
|
All done |
Feature or Bugfix
Detail
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.