refactor(security): Improve security link HTML structure

database-playground · Oct 6, 2024 · 2b0a4af · 2b0a4af
1 parent e694734
commit 2b0a4af
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/assets/styles/app.scss b/assets/styles/app.scss
@@ -87,6 +87,21 @@ ul.credit {
   list-style: none;
   margin-bottom: 0;
   padding-left: 0;
+
+  &__links {
+    display: inline;
+    list-style: none;
+    padding: 0;
+    margin: 0;
+
+    li {
+      display: inline;
+    }
+
+    li:not(:last-child)::after {
+      content: "｜";
+    }
+  }
 }
 
 // overrides

diff --git a/templates/security/login.html.twig b/templates/security/login.html.twig
@@ -58,10 +58,18 @@
 
                 <ul class="app-login__form__login-form__operation__credit credit">
                     <li>
-                        <a href="https://github.com/database-playground/app-sf" target="_blank">GitHub</a
-                        >｜<a href="https://uptime.dbplay.pan93.com">服務狀態</a>｜<a href="{{ url('app_feedback', {url: app.request.uri}) }}" target="_blank">
-                            意見回饋
-                        </a></li>
+                        <ul class="credit__links">
+                            <li>
+                                <a href="https://github.com/database-playground/app-sf" target="_blank">GitHub</a>
+                            </li>
+                            <li>
+                                <a href="https://uptime.dbplay.pan93.com">服務狀態</a>
+                            </li>
+                            <li>
+                                <a href="{{ url('app_feedback', {url: app.request.uri}) }}" target="_blank">意見回饋</a>
+                            </li>
+                        </ul>
+                    </li>
                     <li>Designed by <a href="https://eclab.nkust.edu.tw/" target="_blank">傅家子弟電商實驗室</a></li>
                 </ul>
             </div>