ci: move bindings publish steps to release workflow #743
+66
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove publish parameter and job from reusable workflows - Add dedicated publish jobs in release.yml for PyPI and npm - This avoids PyPI restrictions on publishing from reusable workflows
everpcpc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the bindings release process to avoid PyPI restrictions on publishing from reusable workflows.
Changes
publishparameter and job from reusable workflows (bindings.python.ymlandbindings.nodejs.yml)bindings_python_publishandbindings_nodejs_publishjobs directly inrelease.ymlWhy
PyPI does not allow publishing from reusable workflows (workflow_call). By moving the publish steps to the main release workflow, we can successfully publish Python packages to PyPI while keeping the rest of the CI pipeline modular.
Testing