Open
Conversation
added 2 commits
June 11, 2025 23:51
Add Cohort Builder as re-usable TVF, update dashboard and installer.
erinaldidb
reviewed
Jul 3, 2025
| LANGUAGE SQL | ||
| DETERMINISTIC | ||
| COMMENT "TVF wrapper around object_catalog" | ||
| RETURN SELECT |
Collaborator
There was a problem hiding this comment.
Shall we make this compatible with variants? Adding cast operator should make it work and retrocompatible, "::String"
Collaborator
Author
There was a problem hiding this comment.
Now, I think not. Let's combine the variant changes.
| "# Install all the upfront DDL\n", | ||
| "from dbx.pixels import Catalog\n", | ||
| "catalog = Catalog(spark,table=\"hls_radiology.tcia.object_catalog\")\n", | ||
| "catalog._init_tables()" |
Collaborator
There was a problem hiding this comment.
We could move the init_tables function in the Catalog.__ init__ so this will not be needed.
Collaborator
Author
There was a problem hiding this comment.
I have a (not so?) weird feelings about doing heavy weight operations in a class constructor. Let me look again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add View URL sql function which differentiates on Modality and Image type.
Encapsulate "Cohort Builder" query for re-usability (e.g. Genie)
This PR replaces #114
Add DDL, update DDL installer, update dashboard