Conversation
erinaldidb
reviewed
Jan 27, 2026
.github/workflows/dev-push-lint.yml
Outdated
| @@ -0,0 +1,36 @@ | |||
| name: Test and Lint Python Package | |||
Collaborator
There was a problem hiding this comment.
Please change the name
.github/workflows/dev-push-lint.yml
Outdated
| make style | ||
|
|
||
| - name: Install pre-commit | ||
| run: .venv/bin/pip install pre-commit |
Collaborator
There was a problem hiding this comment.
make this as part of make dev
.github/workflows/dev-push-lint.yml
Outdated
| run: .venv/bin/pip install pre-commit | ||
|
|
||
| - name: Run pre-commit checks | ||
| run: .venv/bin/pre-commit run --all-files |
Collaborator
There was a problem hiding this comment.
this is already part of make style so can be removed
Updated the workflow name and modified the linting steps to use 'make check' instead of pre-commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cracked the code on git action, run stuff out of
.venv/bin