Skip to content

fix(dbclient): Standardized and cleanup#285

Open
RemoteRabbit wants to merge 26 commits intodatabricks-industry-solutions:mainfrom
RemoteRabbit:fix/db-client-script-cleanup
Open

fix(dbclient): Standardized and cleanup#285
RemoteRabbit wants to merge 26 commits intodatabricks-industry-solutions:mainfrom
RemoteRabbit:fix/db-client-script-cleanup

Conversation

@RemoteRabbit
Copy link
Contributor

@RemoteRabbit RemoteRabbit commented Feb 10, 2026

Summary

Update the dbclient file to fix annotations, formatting, missing commas, and other redundant snippets.

✨ Features

  • feat: Update and Add type annotations [d407554]
  • feat: Add a mask data function for keys [021d13d]

🐛 Bug Fixes

  • fix: allow for token cache and make immutable objects [1ecf2e6]
  • fix: update typing [8205963]
  • fix: removed unused vars, replaced with standard _ [e11d19f]
  • fix: remove f string and made base string [3d7d94b]
  • fix: raise error if no spark runtime version found [cf89e33]
  • fix: raise error when no com_id returned [09cdde3]
  • fix: raise error when no json_params are passed instead of just logging out [1dbfd74]
  • fix: set proper error and raise exception [6fc9964]
  • fix: remove is True the if conditional already handles truthy [307f78a]
  • fix: remove NUM_PAGES var since func uses self._maxpages [79f3e6e]
  • fix: remove duplicate strip method [54dc312]
  • fix: other conditionals return one object not a tuple, remove extra None value [73cc2a2]
  • fix: throw error instead of printing to stdout [aa08de6]
  • fix: missing commas [9a45442]
  • fix: change to elif s with error if none match [97aaa6e]
  • fix: force int typing for patterns enum [b37dd5a]
  • fix: remove old legacy code, post dec 2025 [6d1d99b]
  • fix: simplify true claims [a458b6c]
  • fix: Remove unneeded LOGGR = None if loop since it is already set [e90ac82]
  • fix: sort imports PEP 8 [43fe9be]

📚 Documentation

  • docs: Update docstrings, remove old code [b93e8d2]

🔧 Maintenance

📁 File Changes

Securityanalysistoolproject (+931/-721 lines)

  • src/securityanalysistoolproject/core/dbclient.py (+931/-721) 📝

Changes: 1 files, +931 insertions, -721 deletions
Commits: 24
Branch: fix/db-client-script-cleanup
Base: origin/main

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (non-code changes like README or docs)

How Has This Been Tested?

Are there good ways to test this all locally?

Checklist

  • I have reviewed the CONTRIBUTING and VERSIONING documentation.
  • My code follows the code style of this project.
  • I have verified that my changes do not introduce any breaking changes on all the supported clouds (AWS, Azure, GCP).
  • I have verified, added or updated the tests to cover my changes (if applicable).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).

- Before the token would refresh on each call this caches it
- Makes params and dict from user immutable and create copies of it
instead of mutating the actual requests
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@RemoteRabbit RemoteRabbit changed the title [WIP] fix(dbclient): Standardized and cleanup fix(dbclient): Standardized and cleanup Feb 12, 2026
@RemoteRabbit RemoteRabbit marked this pull request as ready for review February 12, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants