Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable acceptance tests for running against the cloud #2120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable acceptance tests for running against the cloud #2120

wants to merge 1 commit into from

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 10, 2025

Changes

  • If CLOUD_ENV variable is set, acceptance will no longer set up server & override DATABRICKS_HOST/DATABRICKS_TOKEN/HOME env vars.
  • I've updated replacements logic in testdiff to use tester / [email protected] convention.

Tests

Manually running current acceptance tests against dogfood on my laptop I get all test pass except for 2 failures.

    --- FAIL: TestAccept/bundle/variables/env_overrides (0.09s)
    --- FAIL: TestAccept/bundle/variables/resolve-builtin (1.30s)

@denik denik temporarily deployed to test-trigger-is January 10, 2025 16:20 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denik