(WIP, not for merging) Standalone WASM+native build of "bundle init" #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~/work/cli/wasm_bundle_init % ls -l bundle_init bundle_init.wasm -rwxr-xr-x@ 1 denis.bilenko staff 5534290 Mar 13 20:26 bundle_init -rwxr-xr-x@ 1 denis.bilenko staff 6751755 Mar 13 20:26 bundle_init.wasm after: ~/work/cli/wasm_bundle_init % ls -l bundle_init bundle_init.wasm -rwxr-xr-x@ 1 denis.bilenko staff 3848802 Mar 13 20:28 bundle_init -rwxr-xr-x@ 1 denis.bilenko staff 6605659 Mar 13 20:28 bundle_init.wasm
~/work/cli/wasm_bundle_init % ls -l bundle_init bundle_init.wasm -rwxr-xr-x@ 1 denis.bilenko staff 3848802 Mar 13 20:28 bundle_init -rwxr-xr-x@ 1 denis.bilenko staff 6605659 Mar 13 20:28 bundle_init.wasm ~/work/cli/wasm_bundle_init % make clean all rm bundle_init bundle_init.wasm GOOS=js GOARCH=wasm go build -ldflags="-w -s" -gcflags=all=-l -o bundle_init.wasm go build -ldflags="-w -s" -gcflags=all=-l -o bundle_init ~/work/cli/wasm_bundle_init % ls -l bundle_init bundle_init.wasm -rwxr-xr-x@ 1 denis.bilenko staff 3585170 Mar 13 20:30 bundle_init -rwxr-xr-x@ 1 denis.bilenko staff 6581078 Mar 13 20:30 bundle_init.wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://databricks.github.io/cli/experimental/template
In this branch, libs/template is hacked not to depend on SDK or file system or readline. Computed values (user_name, workspace_host, default_catalog) need to be provided by the caller.
I’m using client-side decompressor to download gzip (1.4MB), on a real deployment server this won’t be necessary and we can use brotli (1MB). Uncompressed size is 5.7MB.
If we were to productionize this we need to extract smaller rendering library from libs/template, so that wasm build does not depend on SDK (which bloats size: libs/git, libs/filer) or terminal-related utilities (which does not compile: cmdio).