[Python] Fix issues with multiple resource loaders #2511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
kanterov
force-pushed
the
python-fix-resource-loaders
branch
from
b1d2e31 to
fa94355
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
force-pushed
the
python-fix-resource-loaders
branch
from
fa94355 to
774cd98
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Mar 18, 2025
| _load_resources_from_function(bundle, function) | ||
| ) | ||
|
|
||
| resources.add_resources(function_resources) |
There was a problem hiding this comment.
What happens if separate functions use the same resource key?
There was a problem hiding this comment.
We will add a diagnostic error (that will prevent deployment) and return a bundle containing the first resource. There is a test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix issues with multiple resource loaders.
Previously, we discarded outputs of all loaders except the last one. That worked well if there is only a single resource loader.
Tests