Add support for volumes in deployment bind/unbind commands #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
force-pushed
the
anton-107/bind-volumes
branch
from
6248f93 to
8ea8834
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
denik
reviewed
Mar 20, 2025
denik
reviewed
Mar 20, 2025
anton-107
force-pushed
the
anton-107/bind-volumes
branch
from
8ea8834 to
7b9719c
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Mar 21, 2025
|
|
||
| trace $CLI bundle deployment unbind volume1 | ||
|
|
||
| trace $CLI bundle destroy --auto-approve |
There was a problem hiding this comment.
This should also be part of trap, right?
There was a problem hiding this comment.
it is part of the test - in the next command we are verifying that an unbound volume is not destroyed when a bundle is
anton-107
force-pushed
the
anton-107/bind-volumes
branch
from
a896715 to
2a487ba
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FindResourceByConfigKeyto return volume resourcesExistsmethod on Volume resourceWhy
This PR adds support for volume resources in deployment operations, enabling users to:
databricks bundle deployment bind <myvolume_key> <myvolume_full_name>databricks bundle deployment unbind <myvolume_key>Where:
myvolume_keyis a resource key defined in the bundle's .yml filemyvolume_full_namereferences an existing volume in the Databricks workspace using its fully qualified (3-level) nameThese capabilities allow for more flexible resource management of volumes within bundles.
Tests
Added a new acceptance test that tests bind and unbind methods together with bundle deployment and destruction.