Convert default-python integration test to acceptance test #2532
+548
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
pietern,
andrewnester,
shreyas-goenka and
anton-107
as code owners
denik
force-pushed
the
denik/integration-acc-default-python
branch
from
5bea7b2 to
2b9073b
Compare
denik
force-pushed
the
denik/integration-acc-default-python
branch
from
2b9073b to
7deee04
Compare
denik
force-pushed
the
denik/integration-acc-default-python
branch
from
f95ce63 to
5b97c12
Compare
denik
force-pushed
the
denik/integration-acc-default-python
branch
from
4da8eed to
57a5e68
Compare
|
|
||
| >>> [CLI] bundle summary -t prod -o json | ||
|
|
||
| >>> diff.py ../out.summary.dev.json ../out.summary.prod.json |
There was a problem hiding this comment.
This is unexpected; shouldn't there be a diff between mode development and production? For mode: development the resources have a prefix added to them.
There was a problem hiding this comment.
well spotted, thanks! diff.py is not doing anything if arguments are files (as opposed to directories).
denik
force-pushed
the
denik/integration-acc-default-python
branch
from
73fc8b8 to
d2c8774
Compare
pietern
reviewed
Mar 25, 2025
acceptance/bin/diff.py
Outdated
| assert d1.is_file(), d1 | ||
| assert d2.is_file(), d2 | ||
| diff_files(patterns, d1, d2) | ||
| return |
There was a problem hiding this comment.
Was this merged in a different PR?
There was a problem hiding this comment.
Yes, it is rebased now, please take another look.
…pal" This reverts commit 7702d243ca378e354f3b035446b87c1f682640d9.
…r future GCP support" This reverts commit 3f80c0c829b87756830b7d934a88835e3c46e8fb.
denik
force-pushed
the
denik/integration-acc-default-python
branch
from
d2c8774 to
374aabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note, GCP is disabled in this test due to differences from the aws and azure (IsServicePrincipal is false there, causing different config).
Depends on #2535
Why
init_default_python_test.go is one of a kind test - it uses golden files, but it's a separate thing from the rest of acceptance tests. This change makes it easier to update it with the rest of acceptance tests.