Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc: lower case UNIQUE_NAME #2534

Merged
merged 1 commit into from
Mar 20, 2025
+1 −1
Merged

acc: lower case UNIQUE_NAME #2534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
acc: lower case UNIQUE_NAME 
Same reason as for #2380
This makes $UNIQUE_NAME usable in PyPI distribution names, which are lowercased: pypa/setuptools#4766
  • Loading branch information
@denik
denik committed Mar 20, 2025
commit f1f5071c51bb9adc090293ecda6f703fb4970580
2 changes: 1 addition & 1 deletion acceptance/acceptance_test.go
View file
Original file line number Diff line number Diff line change
@@ -311,7 +311,7 @@ func runTest(t *testing.T, dir, coverDir string, repls testdiff.ReplacementsCont
}

id := uuid.New()
uniqueName := strings.Trim(base32.StdEncoding.EncodeToString(id[:]), "=")
uniqueName := strings.ToLower(strings.Trim(base32.StdEncoding.EncodeToString(id[:]), "="))
repls.Set(uniqueName, "[UNIQUE_NAME]")

var tmpDir string