Add support for clusters in deployment bind/unbind commands #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
force-pushed
the
anton-107/bind-cluster
branch
from
4c53b3b to
e357296
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
denik
reviewed
Mar 20, 2025
andrewnester
approved these changes
Mar 20, 2025
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Mar 20, 2025
| @@ -0,0 +1,23 @@ | |||
|
|
|||
| >>> cat databricks.yml | |||
There was a problem hiding this comment.
nit: I'd drop this, it's pretty much the same as committed databricks.yml.tmpl
| @@ -290,6 +290,10 @@ func getSkipReason(config *internal.TestConfig, configPath string) string { | |||
| return fmt.Sprintf("Disabled via RequiresUnityCatalog setting in %s (TEST_METASTORE_ID=%s)", configPath, os.Getenv("TEST_METASTORE_ID")) | |||
| } | |||
|
|
|||
| if isTruePtr(config.RequiresCluster) && os.Getenv("TEST_DEFAULT_CLUSTER_ID") == "" { | |||
There was a problem hiding this comment.
which environments do not have TEST_DEFAULT_CLUSTER_ID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FindResourceByConfigKeyto return cluster resourcesRequiresClusterWhy
This PR adds support for cluster resources in deployment operations, enabling users to:
databricks bundle deployment bind <mycluster_key> <mycluster_id>databricks bundle deployment unbind <mycluster_key>Where:
mycluster_keyis a resource key defined in the bundle's .yml filemycluster_idreferences an existing cluster in the Databricks workspaceThese capabilities allow for more flexible resource management of clusters within bundles.
Tests
Added a new acceptance test that tests bind and unbind methods