Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added save for agent config #35

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

edurdevic
Copy link
Contributor

What changes are proposed in this pull request?

This PR adds a save step for agent configuration. This fixes the notebook 03, which now runs with the specified notebook parameters

How is this PR tested?

Manual testing

Copy link
Collaborator

@prithvikannan prithvikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also remove agent_app_sample_code/agents/generated_configs/agent.yaml now?

@prithvikannan prithvikannan merged commit 9c00212 into databricks:main Oct 11, 2024
2 checks passed
fflory pushed a commit to fflory/genai-cookbook that referenced this pull request Dec 12, 2024
* Added save for agent config

* Removed default agent config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants