Remove unnecessary poetry.lock file and fix tests in OpenAI SDK cookbook code #46
Conversation
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
|
|
||
| CATALOG = "ep" | ||
| SCHEMA = "cookbook_local_test" | ||
|
|
||
|
|
||
| if os.getenv("GITHUB_ACTIONS") == "true": |
There was a problem hiding this comment.
As an alternative, we could mock out the WorkspaceClient APIs & DatabricksFunctionClient in these tests, but skipping these in CI for now for simplicity. It also seems important to actually be able to test UC tool execution against a real backend, given that there are currently differences between local & remote execution. If there weren't, I guess we could just test the actual function definition and assume UC execution works fine
| @@ -2,7 +2,14 @@ jupyter-book | |||
| livereload | |||
| black | |||
| pytest | |||
| mlflow-skinny[databricks] | |||
There was a problem hiding this comment.
I don't think this is needed? at least in the openai SDK folder, I was using poetry to install these locally and had mirrored that to the requirements.txt files there...
There was a problem hiding this comment.
Good point, this is the combined requirements that are installed in CI - but it makes sense to actually mirror user-facing env setup steps in CI (i.e. cd into openai_sdk_agent_app_sample_code and install dependencies via poetry). I'm hoping we can still do that effectively without checking in poetry.lock, unless that buys us better reproducibility than installing python libs via requirements.txt
There was a problem hiding this comment.
(will merge for now to fix CI and see if I can make the CI setup match the dev setup in a followup)
…ook code (databricks#46) * Fix tests Signed-off-by: Sid Murching <[email protected]> * Update reqs Signed-off-by: Sid Murching <[email protected]> * remove dbconnect dep Signed-off-by: Sid Murching <[email protected]> * Skip some tests in GHA Signed-off-by: Sid Murching <[email protected]> --------- Signed-off-by: Sid Murching <[email protected]>
Related Issues/PRs
This PR is a follow-up to #45
What changes are proposed in this pull request?
See title; removes an unnecessary large file & fixes tests in OpenAI SDK cookbook sample code
How is this PR tested?