Skip to content
This repository was archived by the owner on Jul 25, 2025. It is now read-only.

Add support for calling mistral for titling (no public API yet)#1168

Merged
dsmilkov merged 7 commits intomainfrom
ds-cluster-mistral
Feb 8, 2024
Merged

Add support for calling mistral for titling (no public API yet)#1168
dsmilkov merged 7 commits intomainfrom
ds-cluster-mistral

Conversation

@dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Feb 5, 2024

Add support for calling mistral for titling, but without adding public API yet.

  • Add generate_title_mistral and generate_category_mistral titling functions.
  • change the internal cluster_impl so we can override the cluster titling and category titling functions to use those
  • At a later PR when we are happy with quality, we can switch to those by default.

@dsmilkov dsmilkov requested review from brilee and nsthorat February 5, 2024 21:05
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work!

@dsmilkov dsmilkov enabled auto-merge (squash) February 8, 2024 19:26
@dsmilkov dsmilkov disabled auto-merge February 8, 2024 19:31
@dsmilkov dsmilkov merged commit 6cb4f72 into main Feb 8, 2024
@dsmilkov dsmilkov deleted the ds-cluster-mistral branch February 8, 2024 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants