Fix a bug with excess RAM usage during vector computes. #1195
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brilee
approved these changes
Feb 29, 2024
lilac/embeddings/vector_store.py
Outdated
| flat_vector_keys = [key for vector_keys in all_vector_keys for key in (vector_keys or [])] | ||
| all_vectors = self._vector_store.get(flat_vector_keys) | ||
| all_vectors = iter(self._vector_store.get(flat_vector_keys)) |
There was a problem hiding this comment.
don't think you need the iter?
There was a problem hiding this comment.
yep, no longer needed. was using islice but simplified it.
|
|
||
| for loc_chunk in chunks(locs, HNSW_RETRIEVAL_BATCH_SIZE): | ||
| chunk_items = np.array(self._index.get_items(loc_chunk), dtype=np.float32) | ||
| for vector in np.split(chunk_items, chunk_items.shape[0]): |
There was a problem hiding this comment.
probably simpler/shorter:
for i in range(chunk_items.shape[0]):
yield chunk_items[i]
There was a problem hiding this comment.
need to use split here since it doesn't make a copy
dsmilkov
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector stores now return Iterators of np.array vectors.