Add unified --profile flag with text and flamegraph output#642
Merged
stephenamar-db merged 1 commit intomasterfrom Mar 6, 2026
Merged
Add unified --profile flag with text and flamegraph output#642stephenamar-db merged 1 commit intomasterfrom
stephenamar-db merged 1 commit intomasterfrom
Conversation
Replaces the --flamegraph flag with --profile <file> (text output, default) or --profile flamegraph:<file> (folded stack format). Ports the expression-level profiler from universe/jsonnet/profiler, which measures self-time per expression via visitExpr instrumentation, and merges it with the existing flamegraph stack recorder. The text format shows top expressions by self-time, aggregated by file and by expression type, with System.nanoTime overhead estimation. The flamegraph format filters to Apply/ApplyBuiltin/comprehension frames and includes filenames for non-builtin calls. Deletes the old bench/ ProfilingEvaluator and RunProfiler which are superseded by the new CLI-integrated profiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--flamegraph <file>with--profile <file>(text, default) or--profile flamegraph:<file>(folded stack format for flame graphs)universe/jsonnet/profiler: measures self-time per evaluated expression viaEvaluator.visitExprinstrumentation, withSystem.nanoTimeoverhead compensationbench/ProfilingEvaluatorandbench/RunProfiler, superseded by the CLI-integrated profilerTest plan
sjsonnet.jvm[3.3.7].testpasses (140/140)sjsonnet.jvm[2.13.18].compilepassessjsonnet.js[3.3.7].compilepasses--profile /tmp/out.txtproduces text profile--profile flamegraph:/tmp/out.txtproduces filtered folded stack output