Conversation
|
Doc changes are pending. Will take out of draft status when finished. |
connorbrown-db
force-pushed
the
feature/azure-network-redesign
branch
from
e2a4b0c to
95fac1c
Compare
tonykhbo
left a comment
tonykhbo
left a comment
There was a problem hiding this comment.
Nice changes and refactor! Looks good to me.
| @@ -0,0 +1,89 @@ | |||
| locals { | |||
| create_sat_sp = var.sat_configuration.enabled && var.sat_service_principal.client_id == "" | |||
| sat_client_id = local.create_sat_sp ? azuread_service_principal.sat[0].client_id : var.sat_service_principal.client_id | |||
There was a problem hiding this comment.
NIT @connorbrown-db Maybe we should consider renaming the SP so that it's non-exclusive to SAT. Future customizations may leverage the same SP together with the SAT deployment
There was a problem hiding this comment.
For what it's worth, I kind of like it being exclusive to SAT, at least while that's all it's being used for. I think there's an argument for an "administrative" SP at some point, but there's probably counterarguments for separation of concerns as well. Agreed it's not the highest priority to solve.
|
Looks good to me, @connorbrown-db! Thanks for the contributions, I know this is a lot of work! |
BREAKING CHANGE: The metastore no longer includes default storage. Spokes must create catalogs in discrete storage accounts.
BREAKING CHANGE: Azure SRA no longer supports creating spokes in a for_each. Each spoke must now be created as a separate module. This ultimately supports creating workspace objects using a provider per workspace.
…t accidental deletion
connorbrown-db
force-pushed
the
feature/azure-network-redesign
branch
from
9bc7438 to
f418673
Compare
3 participants
Bug Fixes
Features
BREAKING CHANGES