Feature/azure network redesign #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Doc changes are pending. Will take out of draft status when finished. |
BREAKING CHANGE: The metastore no longer includes default storage. Spokes must create catalogs in discrete storage accounts.
BREAKING CHANGE: Azure SRA no longer supports creating spokes in a for_each. Each spoke must now be created as a separate module. This ultimately supports creating workspace objects using a provider per workspace.
connorbrown-db
force-pushed
the
feature/azure-network-redesign
branch
from
e2a4b0c to
95fac1c
Compare
…t accidental deletion
tonykhbo
approved these changes
Apr 16, 2025
| @@ -0,0 +1,89 @@ | |||
| locals { | |||
| create_sat_sp = var.sat_configuration.enabled && var.sat_service_principal.client_id == "" | |||
| sat_client_id = local.create_sat_sp ? azuread_service_principal.sat[0].client_id : var.sat_service_principal.client_id | |||
There was a problem hiding this comment.
NIT @connorbrown-db Maybe we should consider renaming the SP so that it's non-exclusive to SAT. Future customizations may leverage the same SP together with the SAT deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Features
BREAKING CHANGES