Test Case Provider Switch #4135
Open
+358
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfeng-db
requested review from
hectorcast-db
and removed request for
a team
edwardfeng-db
commented
Oct 22, 2024
| @@ -127,23 +135,23 @@ func getDataSourceName(dataSourceFunc func() datasource.DataSource) string { | |||
| } | |||
|
|
|||
| // GetSdkV2ResourcesToRemove is a helper function to get the list of resources that are migrated away from sdkv2 to plugin framework | |||
| func GetSdkV2ResourcesToRemove() []string { | |||
| func GetSdkV2ResourcesToRemove(ctx context.Context) []string { | |||
There was a problem hiding this comment.
Use the context passed through for getting the names
edwardfeng-db
commented
Oct 22, 2024
| useSdkV2 := os.Getenv("USE_SDK_V2_RESOURCES") | ||
| if useSdkV2 == "" { | ||
| return []string{} | ||
| useSdkV2Ctx := ctx.Value("USE_SDK_V2_RESOURCES") |
There was a problem hiding this comment.
key should be a separate type
edwardfeng-db
commented
Oct 22, 2024
| @@ -60,15 +60,15 @@ func GetProviderServer(ctx context.Context, options ...ServerOption) (tfprotov6. | |||
| } | |||
| sdkPluginProvider := serverOptions.sdkV2Provider | |||
| if sdkPluginProvider == nil { | |||
| sdkPluginProvider = sdkv2.DatabricksProvider() | |||
| sdkPluginProvider = sdkv2.DatabricksProvider(ctx) | |||
| } | |||
| pluginFrameworkProvider := serverOptions.pluginFrameworkProvider | |||
There was a problem hiding this comment.
Can provide own options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
make testrun locallydocs/folderinternal/acceptance