Skip to content

[Fix] Use latest etag for access_control_rule_set #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 14, 2025
Merged

[Fix] Use latest etag for access_control_rule_set #4622

merged 9 commits into from
May 14, 2025
+81 −15

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Apr 8, 2025 •
edited
Loading

Changes

  • Add method to fetch latest Etag.
  • Fetch latest etag before update or delete
  • Store empty etag in state as we always fetch the latest

Tests

Updated Unit tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@tanmay-db tanmay-db requested review from a team as code owners April 8, 2025 12:47
@tanmay-db tanmay-db requested review from mgyucht and removed request for a team April 8, 2025 12:47
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:47 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:47 — with GitHub Actions Inactive
@tanmay-db tanmay-db changed the title [Fix] Use latest etag for access_control_rule_set [Fix] Use latest etag for access_control_rule_set Apr 8, 2025
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:48 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 12:49 — with GitHub Actions Inactive
@tanmay-db tanmay-db removed request for a team and mgyucht April 8, 2025 12:52
@tanmay-db tanmay-db marked this pull request as draft April 8, 2025 12:53
@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 12, 2025 17:43 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 12, 2025 17:44 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 12, 2025 17:45 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 12, 2025 17:46 — with GitHub Actions Inactive
@tanmay-db tanmay-db marked this pull request as ready for review May 12, 2025 17:46
@tanmay-db tanmay-db requested review from alexott and 840 May 12, 2025 17:46
840
840 approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@840 840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested internally, changes outside of Terraform are now correctly shown. LGTM

@alexott alexott temporarily deployed to test-trigger-is May 13, 2025 10:40 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is May 13, 2025 10:40 — with GitHub Actions Inactive
@alexott
Copy link
Contributor

alexott commented May 13, 2025

Cc: @gauthamsunjay - can you look?

@tanmay-db tanmay-db force-pushed the terraform-access-control-rule-set branch from a12e2d0 to 7c6d734 Compare May 14, 2025 11:28
@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 14, 2025 11:28 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 14, 2025 11:29 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 14, 2025 11:29 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4622
  • Commit SHA: eba7d28cbd782e8bfbea071334abd4c7cb876729

Checks will be approved automatically on success.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is May 14, 2025 11:30 — with GitHub Actions Inactive
@tanmay-db tanmay-db mentioned this pull request May 14, 2025
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2025
@tanmay-db
[Internal] Update next release version to be patch (#4713)
66cff1a 
## Changes
<!-- Summary of your changes that are easy to understand -->
We use tagging.py which automatically infers version from
NEXT_CHANGELOG. Updating it to patch as we already had SDK generation
and we need to release:
#4622

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->
N/A
- [ ] `make test` run locally
- [ ] relevant change in `docs/` folder
- [ ] covered with integration tests in `internal/acceptance`
- [ ] using Go SDK
- [ ] using TF Plugin Framework
@tanmay-db tanmay-db added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 3e30a02 May 14, 2025
12 checks passed
@tanmay-db tanmay-db deleted the terraform-access-control-rule-set branch May 14, 2025 13:50
deco-sdk-tagging bot added a commit that referenced this pull request May 14, 2025
@deco-sdk-tagging
[Release] Release v1.79.1
341a6c3 
## Release v1.79.1

### Bug Fixes

 * Use latest etag for `access_control_rule_set` [4622](#4622)

### Documentation

 * Explicitly mention SCIM ID in `databricks_group_member` docs [#4709](#4709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@gauthamsunjay gauthamsunjay gauthamsunjay approved these changes

@840 840 840 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanmay-db @alexott @gauthamsunjay @840