Skip to content

Promote Plugin Framework Share Resource to Production #4846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Jul 10, 2025

Changes

This PR promotes the plugin framework implementation of the databricks_share resource to be the default implementation, replacing the SDK v2 version. You can now use databricks_share to access the plugin framework implementation, with an opt-out mechanism available for those who wish to continue using the legacy SDK v2 version.

Rollback Instructions

If you encounter issues with the new plugin framework implementation, you can temporarily revert to the SDK v2 implementation by setting an environment variable:

export USE_SDK_V2_RESOURCES=databricks_share

For data sources, use:

export USE_SDK_V2_DATA_SOURCES=databricks_share,databricks_shares

Tests

Updated all test files to use databricks_share instead of databricks_share_pluginframework.

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework
  • has entry in NEXT_CHANGELOG.md file

@rauchy rauchy requested review from a team as code owners July 10, 2025 10:59
@rauchy rauchy requested review from mgyucht and removed request for a team July 10, 2025 10:59
@rauchy rauchy temporarily deployed to test-trigger-is July 10, 2025 10:59 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is July 10, 2025 11:00 — with GitHub Actions Inactive
@rauchy rauchy force-pushed the omer-lachish_data/promote-pluginfw-share-resource branch from 173623d to 48c9baa Compare July 24, 2025 18:11
@rauchy rauchy temporarily deployed to test-trigger-is July 24, 2025 18:11 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is July 24, 2025 18:12 — with GitHub Actions Inactive
@rauchy rauchy force-pushed the omer-lachish_data/promote-pluginfw-share-resource branch from 48c9baa to 50d60f8 Compare July 24, 2025 20:17
@rauchy rauchy temporarily deployed to test-trigger-is July 24, 2025 20:17 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is July 24, 2025 20:18 — with GitHub Actions Inactive
@rauchy rauchy force-pushed the omer-lachish_data/promote-pluginfw-share-resource branch from 50d60f8 to 32b9c70 Compare July 25, 2025 08:20
@rauchy rauchy temporarily deployed to test-trigger-is July 25, 2025 08:20 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is July 25, 2025 08:21 — with GitHub Actions Inactive
@rauchy rauchy requested review from alexott and tanmay-db July 25, 2025 08:22
@rauchy rauchy force-pushed the omer-lachish_data/promote-pluginfw-share-resource branch from 32b9c70 to adbea4e Compare July 25, 2025 08:40
@rauchy rauchy temporarily deployed to test-trigger-is July 25, 2025 08:40 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4846
  • Commit SHA: adbea4ed69fc35e914b910c6e9daaff6cbbfa0be

Checks will be approved automatically on success.

@rauchy rauchy temporarily deployed to test-trigger-is July 25, 2025 08:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant