Fix handling of force option in databricks_git_credential
#4873
Conversation
With introduction of support for multiple Git credentials the error message did change a bit, so the `force` option may not work in all cases. Resolves #4871
| func isOnlyOneGitCredentialError(err error) bool { | ||
| errStr := err.Error() | ||
| return errors.Is(err, apierr.ErrResourceConflict) || | ||
| (strings.Contains(errStr, "Only one Git credential is supported ") && strings.Contains(errStr, " at this time")) |
There was a problem hiding this comment.
this is the old error message. Are you intending to parse the new one for SPs + multiple git creds? https://sourcegraph.prod.databricks-corp.com/databricks-eng/universe/-/blob/projects/main/scala/credentials/messages/GitCredentialsMessages.scala?L10
There was a problem hiding this comment.
The main question here is - can we rely only on HTTP 409, or do we still need to rely on error messages?
There was a problem hiding this comment.
The case for single credential for SP is handled now via errors.Is(err, apierr.ErrResourceConflict)
Co-authored-by: Grant Eaton <[email protected]>
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
With introduction of support for multiple Git credentials the error message did change a bit, so the
forceoption may not work in all cases.Resolves #4871
Changes
Tests
make testrun locallydocs/folderinternal/acceptanceNEXT_CHANGELOG.mdfile