forked from observatorium/thanos-receive-controller
-
Notifications
You must be signed in to change notification settings - Fork 1
support tenant glob match #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace
* Fix k8s permissions * fix ci * fix ci
- catch up with three OS commits <img width="1249" alt="image" src="https://github.com/user-attachments/assets/6e378b85-1539-48ff-8077-53ef7ca696e2" /> - fix flaky test by sorting hashring endpoints to ensure deterministic results
This PR adds an option to scale hashring to mirror the reference resource. If the option is enabled, instead of getting the number of replicas from sts.Spec, it looks for the CRD as annotated in the sts. Tests are here: https://github.com/databricks-eng/universe/pull/873228
yuchen-db
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. how long have we tested this change in db_main?
we've already rolled dbmain out to prod I think it is tested for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix https://github.com/databricks-eng/universe/pull/924859 and support tenant glob match