Skip to content

support tenant glob match #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 25, 2025
Merged

support tenant glob match #11

merged 16 commits into from
Feb 25, 2025

Conversation

jnyi
Copy link

@jnyi jnyi commented Feb 20, 2025

to fix https://github.com/databricks-eng/universe/pull/924859 and support tenant glob match

christopherzli and others added 16 commits May 16, 2024 09:49
…rium#129)

* support az aware hashring

* Update receive-controller.json

* support multiple statefulsets in 1 hashring

* add more logs

* style

* fix lint issue

* debug

* return when encountering error

* remove whitespace
* Fix k8s permissions

* fix ci

* fix ci
- catch up with three OS commits 
<img width="1249" alt="image"
src="https://github.com/user-attachments/assets/6e378b85-1539-48ff-8077-53ef7ca696e2"
/>

- fix flaky test by sorting hashring endpoints to ensure deterministic
results
This PR adds an option to scale hashring to mirror the reference
resource. If the option is enabled, instead of getting the number of
replicas from sts.Spec, it looks for the CRD as annotated in the sts.
Tests are here: https://github.com/databricks-eng/universe/pull/873228
@jnyi jnyi requested a review from yuchen-db February 20, 2025 17:54
Copy link

@yuchen-db yuchen-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. how long have we tested this change in db_main?

@jnyi
Copy link
Author

jnyi commented Feb 25, 2025

lgtm. how long have we tested this change in db_main?

we've already rolled dbmain out to prod I think it is tested for a while

@jnyi jnyi merged commit c053707 into release Feb 25, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants