-
Notifications
You must be signed in to change notification settings - Fork 5
Support tracing feature #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c491e9
to
22987e7
Compare
e61d83b
to
9099206
Compare
Signed-off-by: Takeshi Arabiki <[email protected]>
Signed-off-by: Takeshi Arabiki <[email protected]>
relay/tendermint/cmd/keys.go
Outdated
|
||
chain, err := coreutil.UnwrapChain[*tendermint.Chain](c) | ||
if err != nil { | ||
return fmt.Errorf("Chain %q is not a tendermint.Chain", args[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not also print the value of err
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this error message without giving it much thought, mainly to avoid a panic in this case 💦
I have improved the error messages in this commit, along with related updates in hyperledger-labs/yui-relayer#164.
Signed-off-by: Takeshi Arabiki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds support for tracing features using tracing bridges, one of which was introduced in hyperledger-labs/yui-relayer#162.
To allow us to try the feature with minimal effort, this PR only focuses on using tracing bridges and logger methods with the
Context
suffix.Since the tracing bridge affects code that uses type assertions and type information (
%T
), so I have verified that there is no remaining code to be updated as follows:This PR modifies the type of the embedded struct within
ProvableChain
, so modules that depends on type assertions need to usecoreutil.UnwrapProver
instead.For example, the following code:
must be updated to: