Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Levriero to Rails 6.1 #142

Merged
merged 14 commits into from
Dec 19, 2023
Merged

Upgrade Levriero to Rails 6.1 #142

merged 14 commits into from
Dec 19, 2023

Conversation

ashwinisukale
Copy link
Contributor

@ashwinisukale ashwinisukale commented Nov 26, 2023

Purpose

closes: #141

Note: we will be merging the changes after schema 4.5 changes.

  1. We will be upgrading the app from rails 6.0 to rails 6.1.
  2. We are considering the Zeitwerk changes.
  3. We are using load_default: 6.1
  4. Fixed failing test which is not related to Rails upgrade.

We do not need to update the Ruby version for Rails 6.1

bundle_report ruby_check --rails-version=6.1.7.3
=> The required ruby version is >= 2.5.0 for matched rails version 6.1.7.3

Gem's compatibility test

bundle_report compatibility --rails-version=6.1  
=> 0 gems incompatible with Rails 6.1

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@ashwinisukale ashwinisukale requested a review from a team November 26, 2023 16:10
@ashwinisukale ashwinisukale self-assigned this Nov 26, 2023
…assenger(R). We strongly recommend upgrading to version 6.0.19.
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone with a bit more knowledge on the infrastructure may need to confirm if the phusion/passenger-full version bump does not require any additional work somewhere else (like mastino).

@ashwinisukale
Copy link
Contributor Author

someone with a bit more knowledge on the infrastructure may need to confirm if the phusion/passenger-full version bump does not require any additional work somewhere else (like mastino).

Yes, there was a security update for this

A security update is available for your version (6.0.18) of Phusion Passenger(R). We strongly recommend upgrading to version 6.0.19.

@digitaldogsbody
Copy link
Member

someone with a bit more knowledge on the infrastructure may need to confirm if the phusion/passenger-full version bump does not require any additional work somewhere else (like mastino).

This should be fine - the container with phusion is built by the workflow, and then pushed as a tagged image to DockerHub and the GitHub container registry, and that tagged image is all mastino cares about, it doesn't have any knowledge of what is actually running inside the container

@ashwinisukale ashwinisukale merged commit 9255e89 into master Dec 19, 2023
2 checks passed
@ashwinisukale ashwinisukale deleted the upgrade_to_6.1 branch December 19, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Levriero to rails 6.1.7.3
4 participants