-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Levriero to Rails 6.1 #142
Conversation
This reverts commit e7d3c67.
…assenger(R). We strongly recommend upgrading to version 6.0.19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone with a bit more knowledge on the infrastructure may need to confirm if the phusion/passenger-full version bump does not require any additional work somewhere else (like mastino).
Yes, there was a security update for this
|
This should be fine - the container with phusion is built by the workflow, and then pushed as a tagged image to DockerHub and the GitHub container registry, and that tagged image is all mastino cares about, it doesn't have any knowledge of what is actually running inside the container |
Purpose
closes: #141
Note: we will be merging the changes after schema 4.5 changes.
We do not need to update the Ruby version for Rails 6.1
Gem's compatibility test
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: